Skip to content

Dawid-Sebastiani score #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Sep 1, 2025
Merged

Dawid-Sebastiani score #104

merged 17 commits into from
Sep 1, 2025

Conversation

@sallen12
Copy link
Collaborator

@sallen12 sallen12 commented Aug 4, 2025 •
edited
Loading

Add Dawid-Sebastiani scores for ensemble forecasts (closes #32):

  • Addresses the remaining tasks listed in Dawid-Sebastiani Score #75
  • Adds univariate and multivariate Dawid-Sebastiani score
  • Adds tests to check that the scores align with scoringRules in R
  • Batch covariance matrix is calculated by looping over all dimensions, which is not very elegant but does work. This can be replaced if a better alternative is thought of

@sallen12 sallen12 mentioned this pull request Aug 5, 2025
Closed
5 tasks
frazane
frazane approved these changes Aug 31, 2025
View reviewed changes
Copy link
Owner

@frazane frazane left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Only minor detail (see below).

scoringrules/_dss.py Outdated
score: Array
The computed Dawid-Sebastiani Score.
"""
backend = backend if backend is not None else backends._active
Copy link
Owner

@frazane frazane Aug 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this line needed?

Copy link
Collaborator Author

@sallen12 sallen12 Sep 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, good spot, have removed. Thanks!

@sallen12 sallen12 merged commit c62cae1 into main Sep 1, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@frazane frazane frazane approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Dawid-Sebastiani Score

4 participants

@sallen12 @frazane @simon-hirsch